docs: make correction in Tutorial toh-pt6 #37516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockument69
added
docsarea: tutorial
effort1: hours
target: patch
|
You can preview 3bc2ada at https://pr37516-3bc2ada.ngbuilds.io/. |
Fixes issue [29535](angular#29535) for the tutorial (toh-pt6) to remove the phrase that directed the reader to delete mock-heroes.ts when it is still needed for further tutorial steps.
rockument69
force-pushed
the
rockument69-tutorial-toh6-edit
branch
from
3bc2ada
to
9cccd0a
Compare
|
You can preview 9cccd0a at https://pr37516-9cccd0a.ngbuilds.io/. |
kapunahelewong
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Docs only change. LGTM. Thanks, @rockument69!
Reviewed-for: global-docs-approvers
jbogarthyde
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Jun 12, 2020
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
Fixes issue [29535](angular#29535) for the tutorial (toh-pt6) to remove the phrase that directed the reader to delete mock-heroes.ts when it is still needed for further tutorial steps. PR Close angular#37516
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Fixes issue [29535](angular#29535) for the tutorial (toh-pt6) to remove the phrase that directed the reader to delete mock-heroes.ts when it is still needed for further tutorial steps. PR Close angular#37516
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 29535 for the tutorial (toh-pt6) to remove the phrase that directed the reader to delete mock-heroes.ts when it is still needed for further tutorial steps.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tutorial toh-pt6 directs reader to delete mock-heroes.ts when it's still being used.
Issue Number: 29535
What is the new behavior?
Replaced sentence so that the user doesn't delete the file.
Does this PR introduce a breaking change?
Other information